Fix wrong key name in unknown decoration option error #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmenke
reviewed
Dec 5, 2024
Comment on lines
22
to
24
| {\tikzerror{Unknown decoration option '\pgfkeyscurrentname'. | ||
| I do not know the key '/pgf/decoration/\pgfkeyscurrentname' | ||
| and I am going to ignore it. Perhaps you misspelled it}}}% |
There was a problem hiding this comment.
Shouldn't we somehow keep the /errors/unknown key handler?
There was a problem hiding this comment.
Using /error/unknown key handler, the full error message looks like
! Package pgfkeys Error: I do not know the key '/pgf/decoration/red' and
I am going to ignore it. Perhaps you misspelled it.
See the pgfkeys package documentation for explanation.
which seems less helpful as user should really be led to the tikz doc, not pgfkeys doc.
But I confess current \tikzerror way is not good too.
There was a problem hiding this comment.
Then maybe an additional error handler for decorations?
There was a problem hiding this comment.
I decided to save time and just switch back to /errors/unknown key.
muzimuzhi
force-pushed
the
gh1082-unknown-decoration
branch
2 times, most recently
from
9248aaf to
ab79a72
Compare
Signed-off-by: Yukai Chou <[email protected]>
Introduced by previous fix pgf-tikz#1083. Signed-off-by: Yukai Chou <[email protected]>
muzimuzhi
force-pushed
the
gh1082-unknown-decoration
branch
from
ab79a72 to
46af807
Compare
|
Sigh, naming of per-issue tests (after 054f118) is still not so consistent. (And sorry for the (force push) noise because I forgot to sign off.) |
hmenke
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #1082.
Previous PR #1083 tried to fix it but left a wrong key name in the error message, see analysis in #1083 (comment) and #1082 (comment).
I also changed it from
pgfkeyserror totikzerror.Checklist
Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead: